docs: record additional worker audit outcomes

2026-05-25 09:02:58 +08:00
parent a270e9c8e0
commit 8b27bd45aa
2 changed files with 11 additions and 0 deletions
@@ -244,6 +244,11 @@ UI / 浏览器可见项必须有真实浏览器截图或结构化 smoke 证据
  - 实测通过：`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task487-local-folder-tree-live-consumer-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task451-local-markdown-conflict-resolution-ui-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task479-local-folder-markdown-resource-lifecycle-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task489-block-menu-delete-undo-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task488-local-attachment-link-delete-undo-smoke.js`。
  - 关键证据：`task487` result 显示 `data-mnote-tree-live-transport=\"local-folder-events\"`、PageTree/FileTree 外部创建/删除后 `treeLiveApplied=\"resync\"`、`navigationEvents=0`；`task451` 覆盖 accept-disk / keep-current / merge-save / agent-conflict-source；`task479` / `task489` / `task488` 均 `ok:true`。
  - 产物：`/mnt/Data1T/mnote-worktrees/0525-am-worker-b-3-20-smoke-regression/tmp/task487-local-folder-tree-live-consumer-smoke/result.json`、`/mnt/Data1T/mnote-worktrees/0525-am-worker-b-3-20-smoke-regression/tmp/task451-local-markdown-conflict-resolution-ui-smoke/result.json`、`/mnt/Data1T/mnote-worktrees/0525-am-worker-b-3-20-smoke-regression/tmp/task489-block-menu-delete-undo-smoke/result.json`、`/mnt/Data1T/mnote-worktrees/0525-am-worker-b-3-20-smoke-regression/tmp/task488-local-attachment-link-delete-undo-smoke/result.json`，以及 `task479` 的系统临时目录截图。
+- 2026-05-25：Batch BB 只派发 1 个只读 Reasonix worker 审计 `uploadFilesWithResolvedTarget` 是否还存在值得继续外置的纯 helper 边界，使用独立 worktree `/mnt/Data1T/mnote-worktrees/0525-bb-worker-a-3-20-upload-boundary-readonly`，run id `reasonix-2026-05-25T00-57-16-343Z-5af1b542`，显式 `--no-memory-recall`。
+  - Codex 已读取 Hindsight recall、`process-handoff.md/json`、`result.json`，并核对该 worktree 源码 `git diff --stat` 为空；worktree 中仅新增 `final.md`、`process-handoff.*`、`result.json` 等审计产物，不视为源码修改。
+  - 审计结论经主控复核后采纳：`uploadFilesWithResolvedTarget(files, detail, options, deps)` 当前已经是合理的薄编排壳层；`deps` 提取与 guard、`resolveFileTreeUploadTarget(detail)` 调用、顺序上传循环、错误收集与 `alert` 反馈均属于当前函数自身职责，不建议继续拆出只会增加间接层的 1-6 行微型 helper。
+  - 主控本地代码证据：`local-upload-runtime.js` 中 `uploadFilesWithResolvedTarget` 目前只保留 `resolveFileTreeUploadTarget` 与 `uploadFileToMediaAsset` 注入、`Array.from(files || []).filter(Boolean)`、顺序上传循环、错误汇总与 `alert`；更低层纯 helper 已分别落地到 `fetchWithTimeout`、`uploadLocalFolderAsset`、`uploadMediaAsset`、`insertUploadedAssetIntoEditor`、`uploadFileToMediaAsset`。
+  - 当前决定：`3-20` 的 local upload 线不再围绕 `uploadFilesWithResolvedTarget` 继续拆刀，下一批改审 `resolveFileTreeUploadTarget` / preflight fallback 或 sidebar refresh 边界。
 - 2026-05-25：Batch AH 由 Codex 主控按当前 goal 明确派发 4 个独立 worktree worker；主工作区不承接实现过程，只读取 Hindsight recall、handoff、diff 与验证证据后裁决。
  - Worker B `/mnt/Data1T/mnote-worktrees/0525-af-worker-b-3-20-filetree-selection-helper`，run `reasonix-2026-05-24T23-33-43-259Z-bd947ad9` 仅产出 `prompt.md` / `memory-recall.json` / `reasonix-transcript.jsonl`，没有 `final.md`、`result.json`、`process-handoff.md/json`；transcript 停在 `submit_plan`，worktree 零 diff，按合同拒收。
  - Worker C `/mnt/Data1T/mnote-worktrees/0525-af-worker-c-3-20-upload-target-readonly`，run `reasonix-2026-05-24T23-33-43-393Z-301491ef` 有完整 `process-handoff.md/json`、`result.json`、`final.md`，源码零 diff；审计结论经主控复核后采纳：`syncSidebarFileTreeSelection` 及 selection runtime 已外置到合理边界，不应回并到 `filetree-runtime.js`；`resolveFileTreeUploadTarget` / `preflightFileTreeUploadTarget` 仍不适合整体迁入 browser runtime，`fileTreeRowsForUploadPreflight` 仅是低优先级候选 helper。