lix/mnote
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract filetree projection helpers

Browse Source
This commit is contained in:
lix-2026
2026-05-25 04:02:36 +08:00
parent 50ed7456ca
commit 9798888909
4 changed files with 183 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design/03-rust-web/process/3-20-browser-runtime-followup-checklist-v1.md
+7
View File
@@ -147,3 +147,10 @@ UI / 浏览器可见项必须有真实浏览器截图或结构化 smoke 证据
- 2026-05-25：Batch L Worker B `reasonix-2026-05-24T19-30-30-509Z-18f62949` 只读审计 `refreshLocalFolderSidebarSnapshot`；Codex 已读取 Hindsight recall、`process-handoff.md/json`、`result.json`，并核对 worktree diff 为空。
- 审计结论：`refreshLocalFolderSidebarSnapshot` 仍是 shell 编排，包含 workspace/root/document 状态、两条 projection fetch、render 后副作用和 watcher 标记，不应整体迁入 `filetree-runtime.js`。
- 下一刀建议：优先迁投影数据读取器层（如 `readProjection`、`readDatasetProjection`、`projectionItems`、row/id/title/file accessor、`groupRowsByParent`），或更保守地先迁未使用的 `replaceSidebarTreeFromDocument`；Codex 本轮不直接实现 3-20 代码，只记录候选。
- 2026-05-25：Batch M 按用户纠正尝试并行派发 3 个 Reasonix 实现 worker，均使用独立 worktree；run `reasonix-2026-05-24T19-40-19-862Z-b3029108` / `reasonix-2026-05-24T19-40-19-873Z-4347ed16` 仅有 `prompt.md`、`memory-recall.json`、`reasonix-transcript.jsonl`，无 `final.md`、`result.json`、`process-handoff.md/json`，不采纳。
- 失败原因：Reasonix ACP 并发串线，Worker C transcript 将 B/C/D 三个任务混为一个选择题并要求人工选择；不满足本文件 handoff 合同。
- 主控处置：不从 Batch M 合入任何 diff；改用 Batch N 的独立 worktree 子 agent worker 继续推进，仍由 Codex 复核 diff 和验证。
- 2026-05-25：Batch N 已启动 2 个 3-20 独立 worktree worker：Worker C `/mnt/Data1T/mnote-worktrees/0525-n-worker-c-3-20-projection-helpers` 负责 filetree projection data helper 外置；Worker D `/mnt/Data1T/mnote-worktrees/0525-n-worker-d-3-20-task435-smoke-assertion` 负责 `task435` local-folder watch projection 断言。Codex 已复核两个 worktree diff 并选择性移植。
- Worker C：`filetree-runtime.js` 新增并导出 `readProjection`、`readSidebarDataset`、`readDatasetProjection`、`projectionItems`、`hasProjectionItems`、`nodeIdOf`、`rowIdOf`、`parentIdOf`、`titleOf`、`fileWorkspaceRelativePath`、`groupRowsByParent`；`layout.rs` 对应 inline fallback 优先委托 `fileTreeRuntimeFunction(...)`，未迁 `refreshLocalFolderSidebarSnapshot` / `startLocalFolderSidebarWatch` / fetch / post-render shell 副作用 / HTML renderer。
- Worker D：`task435-local-folder-watch-no-reload-smoke.js` 新增 `waitForLocalFolderWatchProjectionApplied`，每个外部文件变化步骤前清理旧标记，步骤内显式等待 `data-mnote-local-folder-watch-applied="projection"`，未放宽 no-reload 断言；Codex 同步把初始 `Stable Page` 等待修正为当前 file tree 标题 `stable`。
- 已验证：`node --check rust/crates/mnote-web/browser/filetree-runtime.js`、`node --check scripts/task435-local-folder-watch-no-reload-smoke.js`、`cargo fmt --manifest-path rust/Cargo.toml --all --check`、`cargo check --manifest-path rust/Cargo.toml -p mnote-web`、`cargo test --manifest-path rust/Cargo.toml -p mnote-web filetree_runtime_contains_row_accessor_helpers -- --test-threads=1`、`cargo test --manifest-path rust/Cargo.toml -p mnote-web sidebar_filetree_runtime_helpers_are_externalized_with_inline_fallback -- --test-threads=1`、`cargo test --manifest-path rust/Cargo.toml -p mnote-web sidebar_tree_runtime_polls_local_folder_without_browser_reload -- --test-threads=1`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task435-local-folder-watch-no-reload-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task479-local-folder-markdown-resource-lifecycle-smoke.js`。