lix/mnote
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract selection overlay sync

Browse Source
This commit is contained in:
lix-2026
2026-05-25 05:18:25 +08:00
parent dddf9eb9c1
commit c9d89f2609
5 changed files with 70 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design/05-editor-mainline/process/5-29-editor-runtime-followup-checklist-v1.md
+7
View File
@@ -183,3 +183,10 @@ UI / 浏览器可见项必须有真实浏览器截图或结构化 smoke 证据
- 已验证：`cargo fmt --manifest-path rust/Cargo.toml --all --check`、`cargo check --manifest-path rust/spikes/leptos-tiptap-spike/Cargo.toml`、wasm release build、`wasm-bindgen`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task489-block-menu-delete-undo-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task488-local-attachment-link-delete-undo-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task479-local-folder-markdown-resource-lifecycle-smoke.js`。
- 单元测试阻塞：`cargo test --manifest-path rust/spikes/leptos-tiptap-spike/Cargo.toml block_dnd -- --test-threads=1` 被既有 `STYLE` 测试编译错误阻断，未进入本次新增 helper 测试；该阻断在此前 `block_dnd` 批次已存在。
- 未迁：`hovered_block_from_target`、`drop_indicator_from_target`、`drop_indicator_from_point`、拖拽 listener、block reorder 行为和 DOM -> block 状态解析链仍留在 `lib.rs`。
- 2026-05-25：Batch U 只派发 1 个只读 Reasonix worker 审计 `on_selection_change` overlay 同步边界，使用独立 worktree `/mnt/Data1T/mnote-worktrees/0525-u-worker-a-5-29-selection-overlay-readonly`，run id `reasonix-2026-05-24T21-09-36-422Z-477b50a6`，并显式使用 `--no-memory-recall`。
- Codex 已读取 Hindsight recall、`process-handoff.md/json`、`result.json`、`final.md`，并核对 worktree `git status --short` / `git diff --stat` 为空；Reasonix 未修改源码。runner 完成后残留父进程未自行退出，主控已终止。
- 审计结论经 Codex 复核后采纳：`on_selection_change` 不能整体迁出，因为 selection state 写入和 `send_selection_state_to_target` bridge dispatch 仍属于 `lib.rs` 壳层；其中 text-selection overlay 状态机和互斥 overlay 关闭可作为小 helper 迁入 `editor_runtime/overlays.rs`。
- Codex 主控完成最小切片：`overlays.rs` 新增 `sync_overlays_on_selection_change(...)`，封装 toolbar lock、text selection overlay 同步、image/block overlay 互斥关闭；`lib.rs` 的 `on_selection_change` 仅保留 selection state 写入、helper 调用和 bridge dispatch。
- 修改：`rust/spikes/leptos-tiptap-spike/src/editor_runtime/overlays.rs`、`rust/spikes/leptos-tiptap-spike/src/lib.rs`。
- 已验证：`cargo fmt --manifest-path rust/Cargo.toml --all --check`、`cargo check --manifest-path rust/spikes/leptos-tiptap-spike/Cargo.toml`、wasm release build、`wasm-bindgen`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task489-block-menu-delete-undo-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task488-local-attachment-link-delete-undo-smoke.js`、`MNOTE_WEB_SMOKE_BASE_URL=http://127.0.0.1:3001 NODE_PATH=/mnt/Data1T/mnote/node_modules node scripts/task479-local-folder-markdown-resource-lifecycle-smoke.js`。
- 未迁：`send_selection_state_to_target` / `selection_payload` bridge 链路、`runtime_block_id_from_index`、selection bridge event、`drop_indicator_from_target`、拖拽 listener 和 block reorder 行为仍留在 `lib.rs`。