lix/mnote
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract selection overlay sync

Browse Source
This commit is contained in:
lix-2026
2026-05-25 05:18:25 +08:00
parent dddf9eb9c1
commit c9d89f2609
5 changed files with 70 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rust/spikes/leptos-tiptap-spike/src/editor_runtime/overlays.rs
+40 -1
View File
@@ -2,7 +2,7 @@ use leptos::prelude::{GetUntracked, ReadSignal, Set, WriteSignal};
use crate::{
editor_runtime::block_hover_state::HoveredBlockState,
editor_runtime::dom_selection::active_editor_text_selection,
editor_runtime::dom_selection::{active_editor_text_selection, has_active_text_selection},
editor_runtime::editor_focus::active_editor_stage,
editor_stage_element,
};
@@ -133,6 +133,45 @@ pub(crate) fn toolbar_overlay_locked(
turn_into_open || color_menu_open || more_menu_open
}
#[allow(clippy::too_many_arguments)]
pub(crate) fn sync_overlays_on_selection_change(
turn_into_open: ReadSignal<bool>,
color_menu_open: ReadSignal<bool>,
more_menu_open: ReadSignal<bool>,
text_selection_active: ReadSignal<bool>,
set_text_selection_active: WriteSignal<bool>,
set_floating_toolbar_anchor: WriteSignal<Option<FloatingToolbarAnchor>>,
set_image_toolbar_anchor: WriteSignal<Option<ImageToolbarAnchor>>,
set_turn_into_open: WriteSignal<bool>,
set_block_menu_open: WriteSignal<bool>,
set_block_menu_anchor: WriteSignal<Option<HoveredBlockState>>,
set_hovered_block: WriteSignal<Option<HoveredBlockState>>,
) {
let toolbar_locked = toolbar_overlay_locked(
turn_into_open.get_untracked(),
color_menu_open.get_untracked(),
more_menu_open.get_untracked(),
);
let has_text_selection = if has_active_text_selection() {
sync_text_selection_overlay(set_text_selection_active, set_floating_toolbar_anchor)
} else if toolbar_locked {
text_selection_active.get_untracked()
} else {
set_text_selection_active.set(false);
set_floating_toolbar_anchor.set(None);
false
};
if has_text_selection {
set_image_toolbar_anchor.set(None);
if !toolbar_locked {
set_turn_into_open.set(false);
}
set_block_menu_open.set(false);
set_block_menu_anchor.set(None);
set_hovered_block.set(None);
}
}
#[allow(clippy::too_many_arguments)]
pub(crate) fn close_editor_floating_overlays(
set_slash_open: WriteSignal<bool>,
rust/spikes/leptos-tiptap-spike/src/lib.rs
+14 -27
View File
@@ -36,12 +36,12 @@ use editor_runtime::command_sync::{
read_editor_snapshot, sync_editor_outputs, sync_persisted_editor_command,
};
use editor_runtime::dom_selection::{
has_active_text_selection, selection_summary,
selection_summary,
};
use editor_runtime::editor_focus::{active_editor_stage, body_has_focus, schedule_editor_focus};
use editor_runtime::overlays::{
close_editor_floating_overlays_if_escape, open_block_menu_overlay, open_image_toolbar_overlay,
open_slash_menu_overlay, sync_text_selection_overlay, toolbar_overlay_locked,
open_slash_menu_overlay, sync_overlays_on_selection_change, toolbar_overlay_locked,
try_sync_editor_overlay_state, FloatingToolbarAnchor, ImageToolbarAnchor, TableOverlayAnchor,
TableSelectionKind, TableSelectionOverlayState,
};
@@ -10340,32 +10340,19 @@ fn App(mount_options: MountOptions) -> impl IntoView {
on_selection_change=move |selection: TiptapSelectionState| {
let selection_clone = selection.clone();
set_selection_state.set(selection_clone.clone());
let toolbar_locked = toolbar_overlay_locked(
turn_into_open.get_untracked(),
color_menu_open.get_untracked(),
more_menu_open.get_untracked(),
sync_overlays_on_selection_change(
turn_into_open,
color_menu_open,
more_menu_open,
text_selection_active,
set_text_selection_active,
set_floating_toolbar_anchor,
set_image_toolbar_anchor,
set_turn_into_open,
set_block_menu_open,
set_block_menu_anchor,
set_hovered_block,
);
let has_text_selection = if has_active_text_selection() {
sync_text_selection_overlay(
set_text_selection_active,
set_floating_toolbar_anchor,
)
} else if toolbar_locked {
text_selection_active.get_untracked()
} else {
set_text_selection_active.set(false);
set_floating_toolbar_anchor.set(None);
false
};
if has_text_selection {
set_image_toolbar_anchor.set(None);
if !toolbar_locked {
set_turn_into_open.set(false);
}
set_block_menu_open.set(false);
set_block_menu_anchor.set(None);
set_hovered_block.set(None);
}
if let Some(target) = selection_event_target.as_ref() {
send_selection_state_to_target(
target,